Removed generate_bins_generic #29192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@WillAyd generally looks good. minor comments here or follow-on
|
nice! |
| import pandas.util.testing as tm | ||
| from pandas.util.testing import assert_almost_equal | ||
| from pandas.util.testing import assert_almost_equal, assert_numpy_array_equal |
|
@WillAyd can you rebase; hopefully azure will go through this time |
|
Just restarted build instead to see. These intermittent failures have been rather frustrating lately :-X |
|
one more push to restart CI? |
|
Looks like that one worked |
|
Thanks @jbrockmendel and @simonjayhawkins for review |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appears to be dead groupby code